flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aljoscha <...@git.apache.org>
Subject [GitHub] flink pull request #2434: [FLINK-4496] Refactor the TimeServiceProvider to t...
Date Wed, 21 Sep 2016 15:19:14 GMT
Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2434#discussion_r79854335
  
    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
---
    @@ -365,19 +364,6 @@ public Long getValue() {
     		}
     	}
     
    -	/**
    --- End diff --
    
    This move also seems unnecessary. The current place in the code might not seem ideal but
just moving around code does not help when trying to retrace the history of code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message