flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #2517: [FLINK-4564] [metrics] Delimiter should be configu...
Date Mon, 26 Sep 2016 14:06:06 GMT
Github user zentol commented on a diff in the pull request:

    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistry.java
    @@ -219,9 +249,16 @@ public ScopeFormats getScopeFormats() {
     	public void register(Metric metric, String metricName, MetricGroup group) {
    --- End diff --
    if you change the signature to (Metric, String, AbstractMetricGroup) you would no longer
need the cast on L257.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message