flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aljoscha <...@git.apache.org>
Subject [GitHub] flink issue #2546: [FLINK-4329] Fix Streaming File Source Timestamps/Waterma...
Date Wed, 28 Sep 2016 14:16:52 GMT
Github user aljoscha commented on the issue:

    https://github.com/apache/flink/pull/2546
  
    Just a quick comment (I didn't review all code): Why does this touch the AlignedWindowOperator
tests? I would like to keep this commit as small as possible because we're dealing with sensitive
stuff where I'd like to clearly separate things.
    
    In `OneInputStreamOperatorTestHarness` and `KeyedOneInputStreamOperatorTestHarness`, restricting
the time provider parameter to a `TestTimeServiceProvider` does not change anything, right?
So I think we can leave it as is. Also in `OneInputStreamOperatorTestHarness` the additional
`TimeCharacteristic` parameter is only useful for one specific test so I think it would be
better to instead expose the `StreamConfig` and set the parameter there for the one test to
keep the number of constructors manageable. 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message