flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mushketyk <...@git.apache.org>
Subject [GitHub] flink pull request #2564: [FLINK-2254] Add BipartiateGraph class
Date Thu, 29 Sep 2016 22:17:26 GMT
Github user mushketyk commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2564#discussion_r81246465
  
    --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/Edge.java ---
    @@ -34,10 +34,10 @@
     
     	public Edge(){}
     
    -	public Edge(K src, K trg, V val) {
    -		this.f0 = src;
    -		this.f1 = trg;
    -		this.f2 = val;
    +	public Edge(K source, K target, V value) {
    --- End diff --
    
    To make them consistent with naming style in other classes.
    Do you suggest to revert this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message