flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3930) Implement Service-Level Authorization
Date Thu, 01 Sep 2016 13:29:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15455386#comment-15455386
] 

ASF GitHub Bot commented on FLINK-3930:
---------------------------------------

Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2425#discussion_r77173379
  
    --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JobManagerConfigHandler.java
---
    @@ -40,12 +41,22 @@ public JobManagerConfigHandler(Configuration config) {
     	public String handleRequest(Map<String, String> pathParams, Map<String, String>
queryParams, ActorGateway jobManager) throws Exception {
     		StringWriter writer = new StringWriter();
     		JsonGenerator gen = JsonFactory.jacksonFactory.createGenerator(writer);
    -
     		gen.writeStartArray();
    +
     		for (String key : config.keySet()) {
     			gen.writeStartObject();
     			gen.writeStringField("key", key);
    -			gen.writeStringField("value", config.getString(key, null));
    +			if(key.equals(ConfigConstants.SECURITY_COOKIE)) {
    +				String value = config.getString(key, null);
    +				if(value != null) {
    +					value = "******";
    +				}
    +				gen.writeStringField("value", value);
    +			}
    +			else {
    +				gen.writeStringField("value", config.getString(key, null));
    +			}
    --- End diff --
    
    Good idea not to expose the setting here!
    The `GlobalConfiguration.loadYAMLResource()` method is logging all the key / value pairs.
Maybe it makes sense to hide the value there as well.


> Implement Service-Level Authorization
> -------------------------------------
>
>                 Key: FLINK-3930
>                 URL: https://issues.apache.org/jira/browse/FLINK-3930
>             Project: Flink
>          Issue Type: New Feature
>          Components: Security
>            Reporter: Eron Wright 
>            Assignee: Vijay Srinivasaraghavan
>              Labels: security
>   Original Estimate: 672h
>  Remaining Estimate: 672h
>
> _This issue is part of a series of improvements detailed in the [Secure Data Access|https://docs.google.com/document/d/1-GQB6uVOyoaXGwtqwqLV8BHDxWiMO2WnVzBoJ8oPaAs/edit?usp=sharing]
design doc._
> Service-level authorization is the initial authorization mechanism to ensure clients
(or servers) connecting to the Flink cluster are authorized to do so.   The purpose is to
prevent a cluster from being used by an unauthorized user, whether to execute jobs, disrupt
cluster functionality, or gain access to secrets stored within the cluster.
> Implement service-level authorization as described in the design doc.
> - Introduce a shared secret cookie
> - Enable Akka security cookie
> - Implement data transfer authentication
> - Secure the web dashboard



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message