flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3930) Implement Service-Level Authorization
Date Thu, 01 Sep 2016 13:37:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15455407#comment-15455407
] 

ASF GitHub Bot commented on FLINK-3930:
---------------------------------------

Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2425#discussion_r77174593
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServer.java ---
    @@ -97,6 +101,16 @@ public BlobServer(Configuration config) throws IOException {
     		this.storageDir = BlobUtils.initStorageDirectory(storageDirectory);
     		LOG.info("Created BLOB server storage directory {}", storageDir);
     
    +		if(config.getBoolean(ConfigConstants.SECURITY_ENABLED, DEFAULT_SECURITY_ENABLED) ==
true) {
    +			secureCookie = config.getString(ConfigConstants.SECURITY_COOKIE, null);
    +			if(secureCookie == null) {
    +				String errorMessage = "Missing " + ConfigConstants.SECURITY_COOKIE
    +						+ " configuration in Flink config file";
    +				LOG.error(errorMessage);
    +				throw new IllegalConfigurationException(errorMessage);
    +			}
    +		}
    +
    --- End diff --
    
    This looks a lot like duplicate code. Maybe it makes sense to move it to the `BlobUtils`,
or even to the `SecurityUtils` as a static method, ensuring that security is enabled.


> Implement Service-Level Authorization
> -------------------------------------
>
>                 Key: FLINK-3930
>                 URL: https://issues.apache.org/jira/browse/FLINK-3930
>             Project: Flink
>          Issue Type: New Feature
>          Components: Security
>            Reporter: Eron Wright 
>            Assignee: Vijay Srinivasaraghavan
>              Labels: security
>   Original Estimate: 672h
>  Remaining Estimate: 672h
>
> _This issue is part of a series of improvements detailed in the [Secure Data Access|https://docs.google.com/document/d/1-GQB6uVOyoaXGwtqwqLV8BHDxWiMO2WnVzBoJ8oPaAs/edit?usp=sharing]
design doc._
> Service-level authorization is the initial authorization mechanism to ensure clients
(or servers) connecting to the Flink cluster are authorized to do so.   The purpose is to
prevent a cluster from being used by an unauthorized user, whether to execute jobs, disrupt
cluster functionality, or gain access to secrets stored within the cluster.
> Implement service-level authorization as described in the design doc.
> - Introduce a shared secret cookie
> - Enable Akka security cookie
> - Implement data transfer authentication
> - Secure the web dashboard



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message