flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4455) Replace ActorGateways in NetworkEnvironment by interfaces
Date Thu, 01 Sep 2016 16:09:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15455878#comment-15455878
] 

ASF GitHub Bot commented on FLINK-4455:
---------------------------------------

Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/2449
  
    Thanks for the quick and thorough review @StephanEwen.
    
    - Concerning the `ExecutionContext` in the `TaskManager`: This is simply the `ExecutionContext`
which was passed before to the `NetworkEnvironment` but now is no longer needed there. I agree
that we should be careful with thread pool creations. At the moment, we create for each `JobManager`
and `TaskManager` an additional execution context. The advantage of this approach is that
we separate the actor execution from the execution of other components. Thus, it's not possible
that another component starves the execution context of the actor and thus influences its
responsiveness. But I agree that the few additional future callbacks shouldn't be a big burden
for the `TaskManager` actor system. Will change it.
    
    - It is true that there is no notion of slots on the `TaskManager` right now. I've named
it `SlotEnvironment` because with the Flip-6 refactorings we need to maintain multiple job
manager connections and every task runs in a slot which is associated with a JobManager. Renaming
it to `JobManagerConnection` should better reflect what it actually is.
    
    - Yes that is a good idea. Will try to attach the `ResultPartitionConsumableNotifier`
to the `Task`.


> Replace ActorGateways in NetworkEnvironment by interfaces
> ---------------------------------------------------------
>
>                 Key: FLINK-4455
>                 URL: https://issues.apache.org/jira/browse/FLINK-4455
>             Project: Flink
>          Issue Type: Improvement
>          Components: Network, TaskManager
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>
> The {{NetworkEnvironment}} communicates with the outside world ({{TaskManager}} and {{JobManager}})
via {{ActorGateways}}. This bakes in the dependency on actors. 
> In terms of modularization and an improved abstraction (especially wrt Flip-6) I propose
to replace the {{ActorGateways}} by interfaces which exposes the required methods. The current
implementation would then simply wrap the method calls in messages and send them via the {{ActorGateway}}
to the recipient.
> In Flip-6 the {{JobMaster}} and the {{TaskExecutor}} could simply implement these interfaces
as part of their RPC contract.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message