flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4458) Remove ForkableFlinkMiniCluster
Date Thu, 01 Sep 2016 14:20:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15455536#comment-15455536
] 

ASF GitHub Bot commented on FLINK-4458:
---------------------------------------

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/2450
  
    I think these changes are good.
    
    As a very personal and biased statement: I think the code overdoes it a bit with the "every
parameter on a new line" policy. We have beautiful wide screens and I get sore fingers from
scrolling up and down again to figure out enough context of a code passage ;-)
    
    Also, the style breaks the "visual" separation between different parts of statement, like
"members of a return tuple" vs. "function parameters", or "clauses of an if statement" and
"body of the if statement". I know the idea of that pattern was to improve code readability,
but I am getting the feeling this is approaching a "verschlimmbesserung" (an improvement that
makes things worse).



> Remove ForkableFlinkMiniCluster
> -------------------------------
>
>                 Key: FLINK-4458
>                 URL: https://issues.apache.org/jira/browse/FLINK-4458
>             Project: Flink
>          Issue Type: Improvement
>          Components: Tests
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>
> After addressing FLINK-4424 we should be able to get rid of the {{ForkableFlinkMiniCluster}}
since we no longer have to pre-determine a port in Flink. Thus, by setting the ports to {{0}}
and letting the OS choose a free port, there should no longer be conflicting port requests.
Consequently, the {{ForkableFlinkMiniCluster}} will become obsolete.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message