flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4458) Remove ForkableFlinkMiniCluster
Date Thu, 01 Sep 2016 16:59:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15455997#comment-15455997

ASF GitHub Bot commented on FLINK-4458:

Github user tillrohrmann commented on a diff in the pull request:

    --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/minicluster/FlinkMiniCluster.scala
    @@ -69,7 +69,7 @@ abstract class FlinkMiniCluster(
    -  val configuration = generateConfiguration(userConfiguration)
    +  protected val _configuration = generateConfiguration(userConfiguration)
    --- End diff --
    It's actually the original configuration which will usually have the job manager ipc port
set to 0. Thus, in order to return a configuration which points to the current leader, we
have to generate a new configuration via `configuration` which inserts the selected port.
I'll rename the variable to `originalConfiguration`. 

> Remove ForkableFlinkMiniCluster
> -------------------------------
>                 Key: FLINK-4458
>                 URL: https://issues.apache.org/jira/browse/FLINK-4458
>             Project: Flink
>          Issue Type: Improvement
>          Components: Tests
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
> After addressing FLINK-4424 we should be able to get rid of the {{ForkableFlinkMiniCluster}}
since we no longer have to pre-determine a port in Flink. Thus, by setting the ports to {{0}}
and letting the OS choose a free port, there should no longer be conflicting port requests.
Consequently, the {{ForkableFlinkMiniCluster}} will become obsolete.

This message was sent by Atlassian JIRA

View raw message