flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4458) Remove ForkableFlinkMiniCluster
Date Thu, 01 Sep 2016 17:15:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15456048#comment-15456048

ASF GitHub Bot commented on FLINK-4458:

Github user tillrohrmann commented on the issue:

    Thanks for the review @StephanEwen.
    I agree that we've different style preferences concerning method parameters. I also agree
that the one parameter per line is a little bit more verbose and requires more vertical scrolling.
The best approach would probably be to reduce the number of method parameters by grouping

> Remove ForkableFlinkMiniCluster
> -------------------------------
>                 Key: FLINK-4458
>                 URL: https://issues.apache.org/jira/browse/FLINK-4458
>             Project: Flink
>          Issue Type: Improvement
>          Components: Tests
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
> After addressing FLINK-4424 we should be able to get rid of the {{ForkableFlinkMiniCluster}}
since we no longer have to pre-determine a port in Flink. Thus, by setting the ports to {{0}}
and letting the OS choose a free port, there should no longer be conflicting port requests.
Consequently, the {{ForkableFlinkMiniCluster}} will become obsolete.

This message was sent by Atlassian JIRA

View raw message