flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4528) Mark runAsync and scheduleAsync methods protected
Date Thu, 01 Sep 2016 10:29:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15455027#comment-15455027
] 

ASF GitHub Bot commented on FLINK-4528:
---------------------------------------

Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/2436
  
    After addressing the comments, I'll merge this PR.


> Mark runAsync and scheduleAsync methods protected
> -------------------------------------------------
>
>                 Key: FLINK-4528
>                 URL: https://issues.apache.org/jira/browse/FLINK-4528
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>
> Currently, the {{runAsync}} and {{scheduleAsync}} methods of the {{RpcEndpoint}} are
marked as public. I think that these methods should be protected since nobody should be able
to influence the internal state of an {{RpcEndpoint}} from the outside via these methods.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message