flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4547) Return same object when call connect method in AkkaRpcService using same address and same rpc gateway class
Date Thu, 01 Sep 2016 08:59:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15454822#comment-15454822
] 

ASF GitHub Bot commented on FLINK-4547:
---------------------------------------

GitHub user beyond1920 opened a pull request:

    https://github.com/apache/flink/pull/2455

    [FLINK-4547] [cluster management] Return same object when call connect method in AkkaRpcService
using same address and same rpc gateway class

    The pull request is to add equals and hashCode method to AkkaInvocationHandler class.

    Now every time call connect method in AkkaRpcService class using same address and same
rpc gateway class, the return gateway object is totally different with each other which equals
and hashcode are not same. 
    Maybe it’s reasonable to have the same result (equals return true, and hashcode is same)
when using the same address and same Gateway class.
    
    Main difference are 2 points:
    1. Add equals and hashCode method to AkkaInvocationHandler class
    2. Add a test for connect method in AkkaRpcService


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/alibaba/flink jira-4547

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2455.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2455
    
----
commit 8504f1075b4c4c51f37aab2b45b864f885dc76a3
Author: beyond1920 <beyond1920@126.com>
Date:   2016-09-01T07:00:03Z

    add equals and hashcode in AkkaInvocationHandler

----


> Return same object when call connect method in AkkaRpcService using same address and
same rpc gateway class
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-4547
>                 URL: https://issues.apache.org/jira/browse/FLINK-4547
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination
>            Reporter: zhangjing
>            Assignee: zhangjing
>
> Now every time call connect method in AkkaRpcService class using same address and same
rpc gateway class, the return gateway object is totally different with each other which equals
and hashcode are not same. 
> Maybe it’s reasonable to have the same result (equals return true, and hashcode is
same) when using the same address and same Gateway class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message