flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4615) Reusing the memory allocated for the drivers and iterators
Date Thu, 15 Sep 2016 16:28:21 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15493835#comment-15493835
] 

ASF GitHub Bot commented on FLINK-4615:
---------------------------------------

Github user ggevay commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2496#discussion_r79005879
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/Driver.java ---
    @@ -87,4 +87,6 @@
     	 * @throws Exception Exceptions may be forwarded.
     	 */
     	void cancel() throws Exception;
    +
    +	void resetForIterativeTasks() throws Exception;
    --- End diff --
    
    I think you should use the already existing `ResettableDriver` interface instead of introducing
a new resetting method.


> Reusing the memory allocated for the drivers and iterators
> ----------------------------------------------------------
>
>                 Key: FLINK-4615
>                 URL: https://issues.apache.org/jira/browse/FLINK-4615
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Local Runtime
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 1.0.0
>
>
> Raising as a subtask so that individually can be committed and for better closer reviews.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message