flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tzulitai <...@git.apache.org>
Subject [GitHub] flink issue #2580: [FLINK-4723] [kafka-connector] Unify committed offsets to...
Date Wed, 05 Oct 2016 04:03:58 GMT
Github user tzulitai commented on the issue:

    https://github.com/apache/flink/pull/2580
  
    Thanks for the review @StephanEwen. 
    
    Concerning changing the contract for `commitSpecificOffsetsToKafka`:
    Makes sense, I don't really like excessive copying too. With proper tests on both 0.8
and 0.9, I think it's reasonable to change this. I'll update this, and probably also rename
`commitSpecficOffsetsToKafka` to reflect the contract behaviour.
    
    Thanks for the tip and test stability, I'll do that ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message