flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From KurtYoung <...@git.apache.org>
Subject [GitHub] flink pull request #2571: [FLINK-4348] Simplify logic of SlotManager
Date Thu, 06 Oct 2016 08:11:03 GMT
Github user KurtYoung commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2571#discussion_r82135948
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java
---
    @@ -118,9 +109,9 @@ public void setupResourceManagerServices(ResourceManagerServices resourceManager
     	 * RPC's main thread to avoid race condition).
     	 *
     	 * @param request The detailed request of the slot
    -	 * @return SlotRequestRegistered The confirmation message to be send to the caller
    +	 * @return RMSlotRequestRegistered The confirmation message to be send to the caller
     	 */
    -	public SlotRequestRegistered requestSlot(final SlotRequest request) {
    +	public RMSlotRequestRegistered requestSlot(final SlotRequest request) {
     		final AllocationID allocationId = request.getAllocationId();
     		if (isRequestDuplicated(request)) {
     			LOG.warn("Duplicated slot request, AllocationID:{}", allocationId);
    --- End diff --
    
    Maybe we should return SlotRequestRegistered instead of null when the request is found
duplicated?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message