flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From uce <...@git.apache.org>
Subject [GitHub] flink pull request #2583: [FLINK-4730] Introduce checkpoint meta data
Date Thu, 06 Oct 2016 12:08:46 GMT
Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2583#discussion_r82173079
  
    --- Diff: flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java
---
    @@ -127,12 +125,7 @@
     	 */
     	public FlinkKafkaConsumerBase(List<String> topics, KeyedDeserializationSchema<T>
deserializer) {
     		this.topics = checkNotNull(topics);
    -		checkArgument(topics.size() > 0, "You have to define at least one topic.");
    --- End diff --
    
    +1 to pass a dummy list if possible


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message