flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #2594: [FLINK-4738] [TaskManager] Port TaskManager logic ...
Date Mon, 10 Oct 2016 08:42:31 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2594#discussion_r82563195
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/query/KvStateRegistryGateway.java
---
    @@ -0,0 +1,57 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.query;
    +
    +import org.apache.flink.api.common.JobID;
    +import org.apache.flink.runtime.jobgraph.JobVertexID;
    +import org.apache.flink.runtime.rpc.RpcGateway;
    +import org.apache.flink.runtime.state.KeyGroupRange;
    +
    +public interface KvStateRegistryGateway extends RpcGateway {
    +	/**
    +	 * Notifies the listener about a registered KvState instance.
    +	 *
    +	 * @param jobId            Job ID the KvState instance belongs to
    +	 * @param jobVertexId      JobVertexID the KvState instance belongs to
    +	 * @param keyGroupRange    Key group range the KvState instance belongs to
    +	 * @param registrationName Name under which the KvState is registered
    +	 * @param kvStateId        ID of the KvState instance
    +	 */
    +	void notifyKvStateRegistered(
    +		JobID jobId,
    --- End diff --
    
    It depends a little bit on where the `KvStateRegistry` will be running. If it runs on
the RM, then we would need it. If it's running on the JM, then you're right and we won't need
it. I think for the moment we can leave the queryable state implementation out. Once we've
implemented the basic Flip-6 behaviour, we can also fix the queryable state abstraction.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message