flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request #:
Date Tue, 11 Oct 2016 10:15:49 GMT
Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/commit/6731ec1e48d0a0092dd2330adda73bcf37fda8d7#commitcomment-19375231
  
    In flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/testutils/DataGenerators.java:
    In flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/testutils/DataGenerators.java
on line 186:
    Is this a test for the Kafka producer? Otherwise, it seems that using directly the Kafka
Producer rather than running a dedicated Flink program is simpler and more robust for a test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message