flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #2608: [FLINK-4512] [FLIP-10] Add option to persist perio...
Date Tue, 11 Oct 2016 14:16:21 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2608#discussion_r82778103
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
---
    @@ -219,33 +245,9 @@ public CheckpointCoordinator(
     	 * Shuts down the checkpoint coordinator.
     	 *
     	 * <p>After this method has been called, the coordinator does not accept
    -	 * and further messages and cannot trigger any further checkpoints. All
    -	 * checkpoint state is discarded.
    -	 */
    -	public void shutdown() throws Exception {
    -		shutdown(true);
    -	}
    -
    -	/**
    -	 * Suspends the checkpoint coordinator.
    -	 *
    -	 * <p>After this method has been called, the coordinator does not accept
     	 * and further messages and cannot trigger any further checkpoints.
    -	 *
    -	 * <p>The difference to shutdown is that checkpoint state in the store
    -	 * and counter is kept around if possible to recover later.
    -	 */
    -	public void suspend() throws Exception {
    -		shutdown(false);
    -	}
    -
    -	/**
    -	 * Shuts down the checkpoint coordinator.
    -	 *
    -	 * @param shutdownStoreAndCounter Depending on this flag the checkpoint
    -	 * state services are shut down or suspended.
     	 */
    -	private void shutdown(boolean shutdownStoreAndCounter) throws Exception {
    +	public void shutdown(JobStatus jobStatus) throws Exception {
    --- End diff --
    
    Didn't you tell me that the verb is `shutDown`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message