flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #2608: [FLINK-4512] [FLIP-10] Add option to persist perio...
Date Tue, 11 Oct 2016 14:16:21 GMT
Github user tillrohrmann commented on a diff in the pull request:

    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StandaloneCompletedCheckpointStore.java
    @@ -64,9 +62,9 @@ public void recover() throws Exception {
     	public void addCheckpoint(CompletedCheckpoint checkpoint) throws Exception {
    -		checkpoints.addLast(checkpoint);
    +		checkpoints.add(checkpoint);
     		if (checkpoints.size() > maxNumberOfCheckpointsToRetain) {
    -			checkpoints.removeFirst().discardState();
    +			checkpoints.remove().subsume();
    --- End diff --
    Maybe we shouldn't allow all different combinations of `CheckpointProperties`. Only those
which make sense.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message