flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #2608: [FLINK-4512] [FLIP-10] Add option to persist perio...
Date Tue, 11 Oct 2016 14:16:22 GMT
Github user tillrohrmann commented on a diff in the pull request:

    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CompletedCheckpoint.java
    @@ -51,9 +57,11 @@
     	/** States of the different task groups belonging to this checkpoint */
     	private final Map<JobVertexID, TaskState> taskStates;
    -	/** Flag to indicate whether the completed checkpoint data should be deleted when this
    -	 * handle to the checkpoint is disposed */
    -	private final boolean deleteStateWhenDisposed;
    +	/** Properties for this checkpoint. */
    +	private final CheckpointProperties props;
    +	/** External path if persisted checkpoint; <code>null</code> otherwise.
    +	private final String externalPath;
    --- End diff --
    Ok I see, the path is not fully known when creating the `CheckpointProperties`...

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message