flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #2608: [FLINK-4512] [FLIP-10] Add option to persist perio...
Date Tue, 11 Oct 2016 14:16:22 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2608#discussion_r82799818
  
    --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/messages/JobManagerMessages.scala
---
    @@ -467,8 +467,11 @@ object JobManagerMessages {
         * of triggering and acknowledging checkpoints.
         *
         * @param jobId The JobID of the job to trigger the savepoint for.
    +    * @param savepointDirectory Optional target directory
         */
    -  case class TriggerSavepoint(jobId: JobID) extends RequiresLeaderSessionID
    +  case class TriggerSavepoint(
    +      jobId: JobID,
    +      savepointDirectory : String = null) extends RequiresLeaderSessionID
    --- End diff --
    
    Scalaesque would be to use `Option`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message