flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink pull request #2622: [FLINK-3706] Fix YARN test instability
Date Tue, 11 Oct 2016 14:59:48 GMT
Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2622#discussion_r82809975
  
    --- Diff: flink-yarn-tests/src/test/java/org/apache/flink/yarn/YarnTestBase.java ---
    @@ -599,15 +602,23 @@ protected void runWithArgs(String[] args, String terminateAfterString,
String[]
     					break;
     				}
     			}
    +			if(runner.getRunnerError() != null) {
    +				break; // leave loop to send output and fail with error.
    +			}
     		}
     		while (!expectedStringSeen && System.currentTimeMillis() < deadline);
     		
     		sendOutput();
    +
    +		if(runner.getRunnerError() != null) {
    +			// this lets the test fail.
    +			throw new RuntimeException("Runner failed", runner.getRunnerError());
    +		}
     		Assert.assertTrue("During the timeout period of " + START_TIMEOUT_SECONDS + " seconds
the " +
     				"expected string did not show up", expectedStringSeen);
     
     		// check for 0 return code
    -		Assert.assertEquals("Expected return value", returnCode, runner.getReturnValue());
    +		Assert.assertEquals("Expected return value", expectedReturnValue, runner.getReturnValue());
    --- End diff --
    
    This check is duplicate because it is already performed in the `Runner`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message