flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nssalian <...@git.apache.org>
Subject [GitHub] flink pull request #2618: Refactoring the Continuous File Monitoring Functio...
Date Tue, 11 Oct 2016 19:34:18 GMT
Github user nssalian commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2618#discussion_r82871252
  
    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileMonitoringFunction.java
---
    @@ -107,10 +113,10 @@ public ContinuousFileMonitoringFunction(
     	@Override
     	@SuppressWarnings("unchecked")
     	public void open(Configuration parameters) throws Exception {
    -		LOG.info("Opening File Monitoring Source.");
    -
     		super.open(parameters);
     		format.configure(parameters);
    +
    +		LOG.info("Opening File Monitoring Source for path: " + path + ".");
    --- End diff --
    
    I think "Opening" makes sense since it's describing an action


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message