flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twalthr <...@git.apache.org>
Subject [GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...
Date Wed, 12 Oct 2016 12:29:02 GMT
Github user twalthr commented on a diff in the pull request:

    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/PropertyRead.scala
    @@ -0,0 +1,33 @@
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.api.table.runtime.aggregate
    +import org.apache.flink.streaming.api.windowing.windows.Window
    +  * Base class for reading a window property. The property will be extracted once and
    +  * can be read multiple times.
    +  */
    +trait PropertyRead[T] extends Serializable {
    +  def extract(window: Window): Unit
    --- End diff --
    In general I agree to your solution, but right now we support to have the same operation
multiple times in a query. E.g. 
    .window(Session withGap 3.milli on 'rowtime as 'w)
    .select('string, 'w.end, 'w.end)
    Your code would fail. Let's leave the aggregation as it is for now and rework it again
later. The aggregations have to be reworked anyway for efficiency.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message