flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink pull request #2618: Refactoring the Continuous File Monitoring Functio...
Date Wed, 12 Oct 2016 14:54:09 GMT
Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2618#discussion_r83005541
  
    --- Diff: flink-fs-tests/src/test/java/org/apache/flink/hdfstests/ContinuousFileProcessingTests.java
---
    @@ -54,8 +55,10 @@
     import java.util.List;
     import java.util.Map;
     import java.util.Set;
    +import java.util.TreeSet;
    +import java.util.concurrent.ConcurrentLinkedQueue;
     
    -public class ContinuousFileMonitoringTest {
    +public class ContinuousFileProcessingTests {
    --- End diff --
    
    By convention, unit tests are named `*Test` and integration tests `*ITCase`. Actually,
it affects when they're executed as integration tests will be executed in Maven's `verify`
phase.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message