flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twalthr <...@git.apache.org>
Subject [GitHub] flink pull request #2319: [FLINK-4294] [table] Allow access of composite typ...
Date Sun, 16 Oct 2016 18:20:33 GMT
Github user twalthr commented on a diff in the pull request:

    --- Diff: docs/dev/table_api.md ---
    @@ -1656,6 +1656,29 @@ temporalOverlaps(TIMEPOINT, TEMPORAL, TIMEPOINT, TEMPORAL)
    +    <tr>
    +      <td>
    +        {% highlight java %}
    +{% endhighlight %}
    +      </td>
    +      <td>
    +        <p>Converts a Flink composite type (such as Tuple, POJO, etc.) and all
of its subtypes into a flat representation where every subtype is a separate field.</p>
    +      </td>
    +    </tr>
    +    <tr>
    +      <td>
    +        {% highlight java %}
    --- End diff --
    I thought we only agreed that `getField` is too long. Personally I like this approach
more because it can be found in the expression DSL and has a Scala doc; and it doesn't add
further case distinction logic to the validation layer. Since "$" is valid part of Java identifier
we would also restrict the field naming of POJOs. If there is a consensus I can change it
to "field$substring".

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message