flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink pull request #2425: FLINK-3930 Added shared secret based authorization...
Date Wed, 19 Oct 2016 10:58:01 GMT
Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2425#discussion_r84024531
  
    --- Diff: flink-core/src/main/java/org/apache/flink/configuration/GlobalConfiguration.java
---
    @@ -144,8 +144,15 @@ private static Configuration loadYAMLResource(File file) {
     						continue;
     					}
     
    -					LOG.debug("Loading configuration property: {}, {}", key, value);
     					config.setString(key, value);
    +
    +					//to prevent logging the secure cookie
    +					if(key.equals(ConfigConstants.SECURITY_COOKIE) && value != null) {
    +						value = "******";
    --- End diff --
    
    Could you also do that for the other security-related passwords?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message