flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink pull request #2425: FLINK-3930 Added shared secret based authorization...
Date Wed, 19 Oct 2016 10:58:33 GMT
Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2425#discussion_r84033982
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
    @@ -112,9 +129,9 @@ public void write(ChannelHandlerContext ctx, Object msg, ChannelPromise
promise)
     
     		// Create the frame length decoder here as it depends on the encoder
     		//
    -		// +------------------+------------------+--------++----------------+
    -		// | FRAME LENGTH (4) | MAGIC NUMBER (4) | ID (1) || CUSTOM MESSAGE |
    -		// +------------------+------------------+--------++----------------+
    +		// +------------------+------------------+------------+--------++----------------+
    +		// | FRAME LENGTH (4) | MAGIC NUMBER (4) | COOKIE (4) | ID (1) || CUSTOM MESSAGE |
    +		// +------------------+------------------+------------+--------++----------------+
     		static LengthFieldBasedFrameDecoder createFrameLengthDecoder() {
     			return new LengthFieldBasedFrameDecoder(Integer.MAX_VALUE, 0, 4, -4, 4);
    --- End diff --
    
    You didn't adjust the frame decoder. How is this supposed to work?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message