flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink pull request #2425: FLINK-3930 Added shared secret based authorization...
Date Wed, 19 Oct 2016 10:58:58 GMT
Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2425#discussion_r84035560
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
    @@ -527,13 +591,17 @@ void readFrom(ByteBuf buffer) throws Exception {
     	static class CloseRequest extends NettyMessage {
     
     		private static final byte ID = 5;
    +		String secureCookie = "";
    +
    +		public CloseRequest() {}
     
    -		public CloseRequest() {
    +		public CloseRequest(String secureCookie) {
    +			this.secureCookie = (secureCookie == null) ? "": secureCookie;
    --- End diff --
    
    Please no checks like this. You can use `Preconditions.checkNotNull(secureCookie)`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message