flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kl0u <...@git.apache.org>
Subject [GitHub] flink pull request #2570: [FLINK-3674] Add an interface for Time aware User ...
Date Thu, 20 Oct 2016 08:55:27 GMT
Github user kl0u commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2570#discussion_r84237685
  
    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/DefaultProcessingTimeService.java
---
    @@ -35,10 +34,10 @@
     import static org.apache.flink.util.Preconditions.checkNotNull;
     
     /**
    - * A {@link TimeServiceProvider} which assigns as current processing time the result
of calling
    + * A {@link ProcessingTimeService} which assigns as current processing time the result
of calling
      * {@link System#currentTimeMillis()} and registers timers using a {@link ScheduledThreadPoolExecutor}.
      */
    -public class DefaultTimeServiceProvider extends TimeServiceProvider {
    +public class DefaultProcessingTimeService extends ProcessingTimeService {
     
    --- End diff --
    
    We could also rename it to SystemProcessingTimeService or sth more indicative of where
clock tics come from.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message