flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink pull request #2662: [FLINK-4824] [client] CliFrontend shows misleading...
Date Fri, 21 Oct 2016 09:41:17 GMT
Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2662#discussion_r84448541
  
    --- Diff: flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
    @@ -975,6 +981,32 @@ private int handleArgException(Exception e) {
     	}
     
     	/**
    +	 * Displays an optional exception message for incorrect program parametrization.
    +	 *
    +	 * @param e The exception to display.
    +	 * @return The return code for the process.
    +	 */
    +	private int handleParametrizationException(ProgramParametrizationException e) {
    +		String message = e.getMessage();
    +		if (message != null) {
    +			System.err.println(message);
    +		}
    --- End diff --
    
    This block could be removed if we got rid of the zero-args constructor in `ProgramParametrizationException`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message