flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink pull request #2662: [FLINK-4824] [client] CliFrontend shows misleading...
Date Fri, 21 Oct 2016 09:41:17 GMT
Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2662#discussion_r84448442
  
    --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/ProgramParametrizationException.java
---
    @@ -0,0 +1,46 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.client.program;
    +
    +/**
    + * Exception used to indicate that there is an error in the parametrization of a Flink
program.
    + */
    +public class ProgramParametrizationException extends RuntimeException {
    +	/**
    +	 * Serial version UID for serialization interoperability.
    +	 */
    +	private static final long serialVersionUID = 909054589029890262L;
    +
    +	/**
    +	 * Creates a <tt>ProgramParametrizationException</tt>.
    +	 */
    +	public ProgramParametrizationException() {
    +		super();
    --- End diff --
    
    I think we should not even allow to skip the message here. This will simplify the code
further and display some message for the user.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message