flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ex00 <...@git.apache.org>
Subject [GitHub] flink issue #2650: [FLINK-4563] [metrics] scope caching not adjusted for mul...
Date Fri, 21 Oct 2016 10:40:55 GMT
Github user ex00 commented on the issue:

    https://github.com/apache/flink/pull/2650
  
    Thanks for you review, zentol!
    >oh, I'm afraid i misunderstood the code you posted in the JIRA; i assumed it was to
showcase the behavior from the perspective of a single reporter. Instead of storing a single
scopeString we should store N strings, where N is the number of reporters. In addition, N
filters should be stored as well for comparison.
    
    Do you propose replace ``CharacterFilter firstFilter`` to ``List<CharacterFilter>
filters`` and  ``String scopeString`` to ``List <String> scopeString`` ? and we get
scopeString and filter for reportes via reporterIndex



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message