flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink pull request #2671: [FLINK-4862] fix Timer register in ContinuousEvent...
Date Fri, 21 Oct 2016 13:16:17 GMT
Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2671#discussion_r84464275
  
    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/triggers/ContinuousEventTimeTrigger.java
---
    @@ -45,6 +45,12 @@
     	private final ReducingStateDescriptor<Long> stateDesc =
     			new ReducingStateDescriptor<>("fire-time", new Min(), LongSerializer.INSTANCE);
     
    +	/**
    +	 * Used to preserve the fire timestamp before merge such that
    +	 * the corresponding timer could be cleared after merge
    +	 */
    +	private Long cachedFireTimestamp = null;
    --- End diff --
    
    This doesn't work because there is only one `Trigger` instance and this will potentially
be overwritten by many Windows being merged. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message