flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From thvasilo <...@git.apache.org>
Subject [GitHub] flink issue #2668: Add EvaluateDataSetOperation for LabeledVector. This clos...
Date Fri, 21 Oct 2016 13:26:14 GMT
Github user thvasilo commented on the issue:

    https://github.com/apache/flink/pull/2668
  
    Hello Thomas, thank you for your contribution!
    
    I took a brief look so some initial comments:
    
    This seems to be making changes to `MLUtils` which AFAIK is outside the scope of this
issue. I would recommend you isolate changes into different issues and PRs.
    
    I also see a lot of style changes to existing code. The code style we try to follow is
[this one](https://github.com/databricks/scala-style-guide), I would recommend you review
that and try to follow it. 
    
    As a rule of thumb we don't make style changes to existing code, unless the existing code
does not conform to the linked style. Even in that case I would recommend opening a different
PR with only style changes, as it makes reviewing the core PR (which is the added code here)
easier.
    
    So I'd recommend to remove the style changes you've made from this PR as well. If there
is existing code that violates the linked style we can open a new PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message