flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink pull request #2655: [FLINK-4851] [rm] Introduce FatalErrorHandler and ...
Date Fri, 21 Oct 2016 15:53:48 GMT
Github user mxm commented on a diff in the pull request:

    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/ResourceManagerJobMasterTest.java
    @@ -145,6 +171,10 @@ public void testRegisterJobMasterWithFailureLeaderListener() throws
Exception {
     		Future<RegistrationResponse> declineFuture = resourceManager.registerJobMaster(rmLeaderSessionId,
jmLeaderSessionId, jobMasterAddress, unknownJobIDToHAServices);
     		RegistrationResponse response = declineFuture.get(5, TimeUnit.SECONDS);
     		assertTrue(response instanceof RegistrationResponse.Decline);
    +		if (testingFatalErrorHandler.hasExceptionOccurred()) {
    +			testingFatalErrorHandler.rethrowError();
    +		}
    --- End diff --
    This seems like a lot of boilerplate that we could abstract using a base testing class
for ResourceManager tests.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message