flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink pull request #2669: [FLINK-4871] [mini cluster] Add memory calculation...
Date Fri, 21 Oct 2016 16:16:13 GMT
Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2669#discussion_r84508885
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniClusterConfiguration.java
---
    @@ -162,4 +180,63 @@ public String toString() {
     				", config=" + config +
     				'}';
     	}
    +
    +	/**
    +	 * Calculate the managed memory per task manager. The memory is calculated in the following
    +	 * order:
    +	 *
    +	 * 1. Return {@link #managedMemoryPerTaskManager} if set
    +	 * 2. Return config.getInteger(ConfigConstants.TASK_MANAGER_MEMORY_SIZE_KEY) if set
    +	 * 3. Distribute the available free memory equally among all components (JMs, RMs and
TMs) and
    +	 * calculate the managed memory from the share of memory for a single task manager.
    +	 *
    +	 * @return
    +	 */
    +	private long calculateManagedMemoryPerTaskManager() {
    --- End diff --
    
    `getOrCalculateManagedMemoryPerTaskManager`? 😃


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message