flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink issue #2633: [FLINK-4497] CassadraSink support for scala tuples/case c...
Date Wed, 26 Oct 2016 14:44:31 GMT
Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/2633
  
    Look pretty good.
    
    I think it would be good to try to make the Cassandra Module to the user Scala independent.
That way, we don't introduce a hard requirement for Scala versioning and make this Scala version
independent as soon as Flink's runtime is Scala Version independent.
    
    We can do that the following way:
    
      - Set the Scala dependency to "provided". Flink pulls Scala anyways, Scala users have
Scala anyways always as a dependency. Users that use Scala from Java can always add an additional
Scala dependency in their project.
      - Add the Scala library as a test dependency
      - Drop the Scala compiler plugin
      - Use a case class for the tests that comes in the Scala library (such as Tuple2)
      - Migrate the test to Java - the sink class is in Java anyways
    
    What do you think about that?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message