flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request #2693: [FLINK-4923] [Metrics] Expose input/output buffers...
Date Thu, 27 Oct 2016 12:05:02 GMT
Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2693#discussion_r85322207
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java ---
    @@ -347,6 +348,12 @@ public Task(
     
     		// finally, create the executing thread, but do not start it
     		executingThread = new Thread(TASK_THREADS_GROUP, this, taskNameWithSubtask);
    +
    +		// add metrics for buffers
    +		this.metrics.getIOMetricGroup().getBuffersGroup().gauge("inputQueueLength", new TaskIOMetricGroup.InputBuffersGauge(this));
    --- End diff --
    
    I have rebased merged this already.
    How about doing that in a followup patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message