flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request #2691: [FLINK-4910] Introduce safety net for closing file...
Date Thu, 27 Oct 2016 13:29:27 GMT
Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2691#discussion_r85330501
  
    --- Diff: flink-core/src/main/java/org/apache/flink/util/IOUtils.java ---
    @@ -213,6 +214,16 @@ public static void closeSocket(final Socket sock) {
     			}
     		}
     	}
    +
    +	public static void closeQuietly(Closeable closeable) {
    +		try {
    +			if (closeable != null) {
    +				closeable.close();
    +			}
    +		} catch (IOException silent) {
    --- End diff --
    
    We typically call ignored exceptions `ignored` - that also makes IntelliJ not warn about
ignoring them (if you have the inspection active)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message