flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request #2691: [FLINK-4910] Introduce safety net for closing file...
Date Thu, 27 Oct 2016 13:29:27 GMT
Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2691#discussion_r85329878
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java ---
    @@ -446,6 +447,8 @@ public void startTaskThread() {
     	@Override
     	public void run() {
     
    +		FileSystem.createFileSystemCloseableRegistryForTask();
    --- End diff --
    
    Minor: Can you move that into the beginning of the `try` block? It may be that the task
exits early (immediate cancellation) and then we would not have to create this at all.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message