flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3706) YARNSessionCapacitySchedulerITCase.testNonexistingQueue unstable
Date Tue, 11 Oct 2016 13:56:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15565477#comment-15565477
] 

ASF GitHub Bot commented on FLINK-3706:
---------------------------------------

GitHub user rmetzger opened a pull request:

    https://github.com/apache/flink/pull/2622

    [FLINK-3706] Fix YARN test instability

    The most important change in this commit is that the `YarnTestBase.Runner` doesn't do
`try {} catch (Throwable t) { fail(t); }` anymore, which doesn't lead to a test failure, because
its called outside the main thread.
    With the change, all throwables are reported back to the main thread and fail the test
there properly (many YARN tests benefit from this change).
    
    @mxm could you quickly review the changes? The change is rather small, I was considering
to push a hotfix, but decided to do a quick PR review round.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rmetzger/flink flink3706

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2622.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2622
    
----
commit 7a978a57e4f5845660cff386eb629193dab44109
Author: Robert Metzger <rmetzger@apache.org>
Date:   2016-10-10T15:04:16Z

    [FLINK-3706] Fix YARN test instability
    
    The most important change in this commit is that the `YarnTestBase.Runner` doesn't do
"try {} catch (Throwable t) { fail(t); }" anymore, which doesn't lead to a test failure, because
its called outside the main thread.
    With the change, all throwables are reported back to the main thread and fail the test
there properly (many YARN tests benefit from this change).

----


> YARNSessionCapacitySchedulerITCase.testNonexistingQueue unstable
> ----------------------------------------------------------------
>
>                 Key: FLINK-3706
>                 URL: https://issues.apache.org/jira/browse/FLINK-3706
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Aljoscha Krettek
>            Assignee: Robert Metzger
>            Priority: Critical
>              Labels: test-stability
>         Attachments: log.txt
>
>
> I encountered a failed test on travis.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message