flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4204) Clean up gelly-examples
Date Fri, 21 Oct 2016 16:53:59 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15595656#comment-15595656
] 

ASF GitHub Bot commented on FLINK-4204:
---------------------------------------

Github user vasia commented on the issue:

    https://github.com/apache/flink/pull/2670
  
    Hi @greghogan,
    I really like the cleanup and new organization!
    Two thoughts:
    - is the plan to add drivers for all library methods?
    - shall we remove the `GraphMetrics` example since there is a better driver?


> Clean up gelly-examples
> -----------------------
>
>                 Key: FLINK-4204
>                 URL: https://issues.apache.org/jira/browse/FLINK-4204
>             Project: Flink
>          Issue Type: Improvement
>          Components: Gelly
>    Affects Versions: 1.1.0
>            Reporter: Vasia Kalavri
>            Assignee: Greg Hogan
>
> The gelly-examples has grown quite big (14 examples) and contains several examples that
illustrate the same functionality. Examples should help users understand how to use the API
and ideally show how to use 1-2 features.
> Also, it is helpful to state the purpose of each example in the comments.
> We should keep the example set small and move everything that does not fit there to the
library.
> I propose to remove the following:
> - ClusteringCoefficient: the functionality already exists as a library method.
> - HITS: the functionality already exists as a library method.
> - JaccardIndex: the functionality already exists as a library method.
> - SingleSourceShortestPaths: the example shows how to use scatter-gather iterations.
HITSAlgorithm shows the same feature plus the use of aggregators. I propose we keep this one
instead.
> - TriangleListing: the functionality already exists as a library method



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message