flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4315) Deprecate Hadoop dependent methods in flink-java
Date Mon, 31 Oct 2016 10:39:59 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15621841#comment-15621841
] 

ASF GitHub Bot commented on FLINK-4315:
---------------------------------------

Github user kenmy commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2637#discussion_r85715133
  
    --- Diff: flink-batch-connectors/flink-hadoop-compatibility/src/main/java/org/apache/flink/hadoopcompatibility/FlinkHadoopEnvironment.java
---
    @@ -0,0 +1,143 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.hadoopcompatibility;
    +
    +import org.apache.commons.cli.Option;
    +import org.apache.flink.annotation.PublicEvolving;
    +import org.apache.flink.api.java.DataSet;
    +import org.apache.flink.api.java.ExecutionEnvironment;
    +import org.apache.flink.api.java.hadoop.mapred.HadoopInputFormat;
    +import org.apache.flink.api.java.operators.DataSource;
    +import org.apache.flink.api.java.tuple.Tuple2;
    +import org.apache.flink.api.java.utils.ParameterTool;
    +import org.apache.hadoop.mapred.JobConf;
    +import org.apache.hadoop.mapreduce.Job;
    +import org.apache.hadoop.util.GenericOptionsParser;
    +
    +import java.io.IOException;
    +import java.util.HashMap;
    +import java.util.Map;
    +
    +/**
    + * The FlinkHadoopEnvironment is the context in which a program is executed, connected
with hadoop.
    + *
    + * The environment provides methods to interact with the hadoop cluster (data access).
    + */
    +public final class FlinkHadoopEnvironment {
    --- End diff --
    
    Thank @fhueske for review, . I agree with you, the name HadoopInputs is more suitable
here. I renamed it. Moreover I extracted paramsFromGenericOptionsParser into the new class
HadoopUtils. HadoopInputs was too unsuitable as place for it.


> Deprecate Hadoop dependent methods in flink-java
> ------------------------------------------------
>
>                 Key: FLINK-4315
>                 URL: https://issues.apache.org/jira/browse/FLINK-4315
>             Project: Flink
>          Issue Type: Task
>          Components: Java API
>            Reporter: Stephan Ewen
>            Assignee: Evgeny Kincharov
>             Fix For: 2.0.0
>
>
> The API projects should be independent of Hadoop, because Hadoop is not an integral part
of the Flink stack, and we should have the option to offer Flink without Hadoop dependencies.
> The current batch APIs have a hard dependency on Hadoop, mainly because the API has utility
methods like `readHadoopFile(...)`.
> I suggest to deprecate those methods and add helpers in the `flink-hadoop-compatibility`
project.
> FLINK-4048 will later remove the deprecated methods.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message