flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4563) [metrics] scope caching not adjusted for multiple reporters
Date Fri, 21 Oct 2016 10:40:58 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15594760#comment-15594760
] 

ASF GitHub Bot commented on FLINK-4563:
---------------------------------------

Github user ex00 commented on the issue:

    https://github.com/apache/flink/pull/2650
  
    Thanks for you review, zentol!
    >oh, I'm afraid i misunderstood the code you posted in the JIRA; i assumed it was to
showcase the behavior from the perspective of a single reporter. Instead of storing a single
scopeString we should store N strings, where N is the number of reporters. In addition, N
filters should be stored as well for comparison.
    
    Do you propose replace ``CharacterFilter firstFilter`` to ``List<CharacterFilter>
filters`` and  ``String scopeString`` to ``List <String> scopeString`` ? and we get
scopeString and filter for reportes via reporterIndex



> [metrics] scope caching not adjusted for multiple reporters
> -----------------------------------------------------------
>
>                 Key: FLINK-4563
>                 URL: https://issues.apache.org/jira/browse/FLINK-4563
>             Project: Flink
>          Issue Type: Bug
>          Components: Metrics
>    Affects Versions: 1.1.0
>            Reporter: Chesnay Schepler
>            Assignee: Anton Mushin
>
> Every metric group contains a scope string, representing what entities (job/task/etc.)
a given metric belongs to, which is calculated on demand. 
> Before this string is cached a CharacterFilter is applied to it, which is provided by
the callee, usually a reporter. This was done since different reporters have different requirements
in regards to valid characters. The filtered string is cached so that we don't have to refilter
the string every time.
> This all works fine with a single reporter; with multiple however it is completely broken
as only the first filter is ever applied.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message