flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4669) scala api createLocalEnvironment() function add default Configuration parameter
Date Mon, 10 Oct 2016 10:00:31 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15561853#comment-15561853

ASF GitHub Bot commented on FLINK-4669:

Github user StephanEwen commented on the issue:

    Code looks good, but the build detected a break in binary compatibility. Have a look at
the Travis logs.
    Changing the `createLocalEnvironment` to use an additional parameter with default value
broke the compatibility. The fix would be to have an extra method (and no default parameter
value), not change the existing method.

> scala api createLocalEnvironment() function add default Configuration parameter
> -------------------------------------------------------------------------------
>                 Key: FLINK-4669
>                 URL: https://issues.apache.org/jira/browse/FLINK-4669
>             Project: Flink
>          Issue Type: Improvement
>          Components: Streaming
>            Reporter: shijinkui
> scala program can't direct use createLocalEnvironment with custom Configure object.
> such as I want to start web server in local mode, I will do such as:
> ```
> // set up execution environment
> val conf = new Configuration
> conf.setBoolean(ConfigConstants.LOCAL_START_WEBSERVER, true)
> conf.setInteger(ConfigConstants.JOB_MANAGER_WEB_PORT_KEY, ConfigConstants.DEFAULT_JOB_MANAGER_WEB_FRONTEND_PORT)
> val env = new org.apache.flink.streaming.api.scala.StreamExecutionEnvironment(
>   org.apache.flink.streaming.api.environment.StreamExecutionEnvironment.createLocalEnvironment(2,
> )
> ```
> so we need createLocalEnvironment function have a config parameter 

This message was sent by Atlassian JIRA

View raw message