flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4691) Add group-windows for streaming tables
Date Wed, 12 Oct 2016 13:05:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15568653#comment-15568653

ASF GitHub Bot commented on FLINK-4691:

Github user fhueske commented on a diff in the pull request:

    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/typeutils/RowIntervalTypeInfo.scala
    @@ -0,0 +1,108 @@
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.api.table.typeutils
    +import java.util.Objects
    +import org.apache.flink.api.common.ExecutionConfig
    +import org.apache.flink.api.common.typeinfo.{AtomicType, TypeInformation}
    +import org.apache.flink.api.common.typeutils.base.{LongComparator, LongSerializer}
    +import org.apache.flink.api.common.typeutils.{TypeComparator, TypeSerializer}
    +import org.apache.flink.api.table.typeutils.RowIntervalTypeInfo.instantiateComparator
    +import org.apache.flink.util.Preconditions._
    +  * TypeInformation for row intervals.
    +  */
    +class RowIntervalTypeInfo[T](
    --- End diff --
    OK, I understand the issue with the instance checks (although I would think these checks
are not correct if they fail in such a cases). 
    However, providing a full implementation for each internal type does not seem right. How
about we create a special abstract TypeInfo for types that are not required at execution time
and implement all irrelevant methods (arity, serializer, comparator, etc.) with `UnsupportedOperationException`.
`RowIntervalTypeInfo` and `TimeIntervalTypeInfo` would extend that and just provide the type.

> Add group-windows for streaming tables	
> ---------------------------------------
>                 Key: FLINK-4691
>                 URL: https://issues.apache.org/jira/browse/FLINK-4691
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Timo Walther
>            Assignee: Timo Walther
> Add Tumble, Slide, Session group-windows for streaming tables as described in [FLIP-11|https://cwiki.apache.org/confluence/display/FLINK/FLIP-11%3A+Table+API+Stream+Aggregations].

> Implementation of group-windows on streaming tables. This includes implementing the API
of group-windows, the logical validation for group-windows, and the definition of the “rowtime”
and “systemtime” keywords. Group-windows on batch tables won’t be initially supported
and will throw an exception.

This message was sent by Atlassian JIRA

View raw message