flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4720) Implement an archived version of the execution graph
Date Mon, 10 Oct 2016 12:32:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15562177#comment-15562177
] 

ASF GitHub Bot commented on FLINK-4720:
---------------------------------------

Github user mxm commented on the issue:

    https://github.com/apache/flink/pull/2577
  
    Thanks for the pr @zentol. Looks good to me! A couple of things I noticed: 
    
    - The prefix of the interfaces (`Access*`) could be a bit confusing. What about these?
      - interface: `ExecutionGraph`
      - runtime:`RuntimeExecutionGraph`
      - archive: `ArchivedExecutionGraph` 
    
      That said, you probably chose to not rename the existing `ExecutionGraph` class to minimize
changes.
    
    - How about having an interface `Archiveable<T extends Serializable>` containing
the `T archive()` method? This interface could be implemented by all runtime classes which
are archievable.
    
    - You chose not to port the `ExecutionConfig` or `ExecutionConfigSummary` to your changes
while rebasing?
    



> Implement an archived version of the execution graph
> ----------------------------------------------------
>
>                 Key: FLINK-4720
>                 URL: https://issues.apache.org/jira/browse/FLINK-4720
>             Project: Flink
>          Issue Type: Improvement
>          Components: JobManager, Webfrontend
>    Affects Versions: 1.1.2
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>             Fix For: 1.2.0
>
>
> In order to implement a job history server, as well as separate the JobManager from the
WebInterface, we require an archived version of the ExecutionGraph that is Serializable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message