flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4728) Replace reference equality with object equality
Date Mon, 03 Oct 2016 20:42:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15543370#comment-15543370
] 

ASF GitHub Bot commented on FLINK-4728:
---------------------------------------

GitHub user greghogan opened a pull request:

    https://github.com/apache/flink/pull/2582

    [FLINK-4728] [core,optimizer] Replace reference equality with object equality

    Some cases of testing Integer equality using == rather than Integer.equals(Integer), and
some additional cleanup.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/greghogan/flink 4728_replace_reference_equality_with_object_equality

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2582.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2582
    
----
commit 409883eb3c3ffa7a94ad25e67cfd6dfdc25010ba
Author: Greg Hogan <code@greghogan.com>
Date:   2016-10-03T17:59:57Z

    [FLINK-4728] [core,optimizer] Replace reference equality with object equality
    
    Some cases of testing Integer equality using == rather than
    Integer.equals(Integer), and some additional cleanup.

----


> Replace reference equality with object equality
> -----------------------------------------------
>
>                 Key: FLINK-4728
>                 URL: https://issues.apache.org/jira/browse/FLINK-4728
>             Project: Flink
>          Issue Type: Improvement
>          Components: Core, Optimizer
>    Affects Versions: 1.2.0
>            Reporter: Greg Hogan
>            Assignee: Greg Hogan
>            Priority: Minor
>             Fix For: 1.2.0
>
>
> Some cases of testing {{Integer}} equality using {{==}} rather than {{Integer.equals(Integer)}},
and some additional cleanup.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message